feat: 자체 회원가입 시 noContent로 반환 설정 (#4)

Mapdagu · Aug 15, 2023 · 2f075e1 · 2f075e1
1 parent d626cf4
commit 2f075e1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 15 deletions.
diff --git a/src/main/java/com/project/mapdagu/domain/auth/controller/SignUpController.java b/src/main/java/com/project/mapdagu/domain/auth/controller/SignUpController.java
@@ -5,7 +5,6 @@
 import com.project.mapdagu.domain.auth.dto.request.SignUpRequestDto;
 import com.project.mapdagu.domain.auth.dto.request.SocialSignUpRequestDto;
 import com.project.mapdagu.domain.auth.dto.response.EmailResponseDto;
-import com.project.mapdagu.domain.auth.dto.response.SignUpResponseDto;
 import com.project.mapdagu.domain.auth.dto.response.SocialSignUpResponseDto;
 import com.project.mapdagu.domain.auth.service.AuthService;
 import com.project.mapdagu.domain.auth.service.EmailService;
@@ -30,11 +29,14 @@ public class SignUpController {
     private final AuthService authService;
     private final EmailService emailService;
 
-    @Operation(summary = "자체 회원가입", description = "이메일을 사용해 회원가입을 합니다.")
+    @Operation(summary = "자체 회원가입", description = "이메일을 사용해 회원가입을 합니다.",
+            responses = {@ApiResponse(responseCode = "204", description = "자체 회원가입 성공")
+                    , @ApiResponse(responseCode = "400", description = "1. 이미 존재하는 이메일입니다. \t\n 2. 이미 존재하는 사용자 이름입니다.", content = @Content(schema = @Schema(implementation = ResponseEntity.class)))
+    })
     @PostMapping
-    public ResponseEntity<SignUpResponseDto> signUp(@RequestBody SignUpRequestDto signUpRequestDto) {
-        SignUpResponseDto signUpResponseDto = authService.signUp(signUpRequestDto);
-        return ResponseDto.created(signUpResponseDto);
+    public ResponseEntity<Void> signUp(@RequestBody SignUpRequestDto signUpRequestDto) {
+        authService.signUp(signUpRequestDto);
+        return ResponseDto.noContent();
     }
 
     @Operation(summary = "소셜 추가 회원가입", description = "소셜 로그인 유저 대상으로 추가 회원가입을 합니다.",

diff --git a/src/main/java/com/project/mapdagu/domain/auth/dto/response/SignUpResponseDto.java b/src/main/java/com/project/mapdagu/domain/auth/dto/response/SignUpResponseDto.java
diff --git a/src/main/java/com/project/mapdagu/domain/auth/service/AuthService.java b/src/main/java/com/project/mapdagu/domain/auth/service/AuthService.java
@@ -2,7 +2,6 @@
 
 import com.project.mapdagu.domain.auth.dto.request.SignUpRequestDto;
 import com.project.mapdagu.domain.auth.dto.request.SocialSignUpRequestDto;
-import com.project.mapdagu.domain.auth.dto.response.SignUpResponseDto;
 import com.project.mapdagu.domain.auth.dto.response.SocialSignUpResponseDto;
 import com.project.mapdagu.domain.member.entity.Member;
 import com.project.mapdagu.domain.member.entity.Role;
@@ -32,7 +31,7 @@ public class AuthService {
     private final JwtService jwtService;
     private final RedisUtil redisUtil;
 
-    public SignUpResponseDto signUp(SignUpRequestDto signUpRequestDto) {
+    public void signUp(SignUpRequestDto signUpRequestDto) {
 
         if (memberRepository.existsByEmail(signUpRequestDto.email())) {
             throw new BusinessException(ALREADY_EXIST_EMAIL);
@@ -44,7 +43,6 @@ public SignUpResponseDto signUp(SignUpRequestDto signUpRequestDto) {
         Member member = signUpRequestDto.toEntity();
         member.passwordEncode(passwordEncoder);
         memberRepository.save(member);
-        return SignUpResponseDto.of(member.getId(), member.getUserName());
     }
 
     public SocialSignUpResponseDto socialSignUp(SocialSignUpRequestDto socialSignUpRequestDto, HttpServletRequest request, HttpServletResponse response) {