Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor returnAsDict query mode #191

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Refactor returnAsDict query mode #191

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d65523f
Refactor returnAsDict query mode
bhirsz Nov 5, 2023
835c772
Merge branch 'master' into refactor_return_as_dict
amochin Nov 6, 2023
b889b6c
Typo in var "all_rows"
amochin Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/DatabaseLibrary/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,8 @@ def query(self, selectStatement, sansTran=False, returnAsDict=False):
self.__execute_sql(cur, selectStatement)
all_rows = cur.fetchall()
if returnAsDict:
mapped_rows = []
col_names = [c[0] for c in cur.description]

for rowIdx in range(len(all_rows)):
d = {}
for colIdx in range(len(all_rows[rowIdx])):
d[col_names[colIdx]] = all_rows[rowIdx][colIdx]
mapped_rows.append(d)
return mapped_rows

return [dict(zip(col_names, row)) for row in all_rows]
return all_rows
finally:
if cur and not sansTran:
Expand Down