Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo's: #3998

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Fix typo's: #3998

merged 6 commits into from
Jan 28, 2025

Conversation

loomanw
Copy link
Contributor

@loomanw loomanw commented Jan 17, 2025

detaul->default
tranlsation->translation
transofrormer->transformer
trasform->transform

detaul->default
tranlsation->translation
transofrormer->transformer
trasform->transform
@aaltat
Copy link
Member

aaltat commented Jan 26, 2025

Looks good to me, fixes #4017

@allcontributors please add @loomanw for code

Copy link
Contributor

@aaltat

@loomanw already contributed before to code

@aaltat
Copy link
Member

aaltat commented Jan 26, 2025

This seems to break some tests, please take a look.

@aaltat
Copy link
Member

aaltat commented Jan 27, 2025

Some unit tests did break, could you take a look?

@loomanw
Copy link
Contributor Author

loomanw commented Jan 27, 2025

Updated the approved files and atests.

@aaltat
Copy link
Member

aaltat commented Jan 28, 2025

Thank you for the contribution.

@aaltat aaltat merged commit 4c2f6bb into MarketSquare:main Jan 28, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants