Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MovieApp-JS-Capstone-Project-Review #29

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

MovieApp-JS-Capstone-Project-Review #29

wants to merge 33 commits into from

Conversation

Marlyn-Mayienga
Copy link
Owner

@Marlyn-Mayienga Marlyn-Mayienga commented Sep 9, 2022

The link to the video descriptions is here: video

In this module, we:

  • built these interfaces:

  • The home page.

  • The comments popup and styled them.

  • When the page loads, the web app retrieves data from:

  • The selected API shows the list of items on the screen.

  • The Involvement API to show the item likes.

  • The API retrieves data from:

  • One to the base API.

  • And one to the Involvement API.

  • When the user clicks on the Like button of an item, the interaction is recorded in the Involvement API and the screen is updated.

  • When the user clicks on the "Comments" button, the Comments popup appears.

  • Comments popup

  • When the popup loads, the web app retrieves data from:

  • The selected API shows details about the selected item.

  • The Involvement API to show the item comments.

  • When the user clicks on the "Comment" button, the data is recorded in the Involvement API and the screen is updated.

  • When the popup loads, the web app retrieves data from the selected API and shows details about the selected item.

Copy link

@AmaduKamara AmaduKamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved 🟢🟢🟢

Hi @Marlyn-Mayienga and @Ademola-coding,

Your project is complete!

ClappingLeonardoDicaprioGIF (4)

Highlights:

✅ You used Gitflow correctly
✅ No linter error
✅ README is professional
✅ Good commit messages
✅ Good descriptive PR
✅ Good video presentation
✅ App works fine as expected

There is nothing else to say other than... it's time to merge it: ship it:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants