Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for selecting a different bundle #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bpisano
Copy link

@bpisano bpisano commented Feb 7, 2025

This PR adds support for selecting a different bundle instead of always using the main bundle when generating acknowledgements. The bundle parameter is optional and default to the main bundle to keep the simple syntax of Acknowledgements.all().

if let bundle = Bundle(identifier: "my.bundle") {
    let ack = Acknowledgements.all(in: bundle)
}

I updated the documentation of the .all() function.

I also updated the AcknowledgementsList component with the same bundle parameter.

struct ContentView: View {
    let bundle: Bundle

    var body: some View {
        AcknowledgementsList(bundle: bundle)
    }
}

Let me know if you have any comment. Thanks for this great package!

Copy link
Owner

@MartinP7r MartinP7r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants