Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bsc -> bnb #13

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

bsc -> bnb #13

wants to merge 1 commit into from

Conversation

chaptiste
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Aug 5, 2022

DEV-1065 Data migration: `bsc:` -> `bnb:`

The BSC chain was renamed BNB chain. We must migrate our records at some point.

To do:

  • Migrate all bsc:records in the back, e.g. owners, addresses, portfolios
  • Migrate hard coded constants in the frontend e.g. stablecoin addresses
  • Ensure the frontend/lib/backend does not rely on any bsc: matching

oguimbal
oguimbal requested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@oguimbal oguimbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cf mon commentaire sur l'issue

je mets en "request changes" pour qu'on ne merge pas par erreur, ce replace n'est que la partie emergée de l'iceberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oguimbal oguimbal oguimbal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaptiste @oguimbal