Permitting rhs properties in filters (2) #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauliusg
added
the
PR/ready-for-review
rartino
previously approved these changes
Jul 20, 2019
|
@sauliusg; could you give me writing access to your fork? Then I will update the part in |
main text is now in RST instead of MD.
|
@rartino @merkys @giovannipizzi @CasperWA : please review the port to RST and approve it if you find it right so that it does not get into conflict again :) |
rartino
approved these changes
Nov 3, 2019
merkys
added a commit
to Materials-Consortia/OPTIMADE-Filter
that referenced
this pull request
Dec 5, 2019
merkys
added a commit
to Materials-Consortia/OPTIMADE-Filter
that referenced
this pull request
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding grammar rules to the Filter EBNF grammar to permit 'property CONTAINS another_property' constructs, which are described in the specification as optional features.
This PR is based, as discussed in (#161), on the most recent develop branch, but otherwise has the same relevant changes; I'll close that previous PR.