Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify grouping of relationships and what key to use in JSON:API output format #438

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Clarify grouping of relationships and what key to use in JSON:API output format #438

merged 1 commit into from
Dec 19, 2022

Conversation

rartino
Copy link
Contributor

@rartino rartino commented Dec 19, 2022

Resolves #419 which we found to be blocking for #386 and probably should be addressed for the v1.2 release planning (#429)

ml-evs
ml-evs approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rartino, this seems clear enough to me.

merkys
merkys approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@merkys merkys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly how I had understood it before, but later on found that JSON:API did not contain such constraint. Anyway, I see benefit in adding such constraint, thanks for creating a PR for that.

@rartino rartino merged commit 4dd13b5 into Materials-Consortia:develop Dec 19, 2022
@rartino rartino mentioned this pull request Dec 19, 2022
Open
@ml-evs ml-evs added this to the v1.2 milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merkys merkys merkys approved these changes

@ml-evs ml-evs ml-evs approved these changes

@jvita jvita Awaiting requested review from jvita

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Specification unclear on the key to use in JSON:API relationships
3 participants
@rartino @ml-evs @merkys