Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add per entry and per property meta data field. #463

Merged
merged 43 commits into from
Jun 16, 2023
Merged

Add per entry and per property meta data field. #463

merged 43 commits into from
Jun 16, 2023

Commits on Apr 6, 2023

  1. First draft metadata field.

    @JPBergsma
    JPBergsma committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    4170937 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. updated example so the numbers make sense.

    @JPBergsma
    JPBergsma committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    92c4d92 View commit details
    Browse the repository at this point in the history

  2. Added that metadata fields can have their own metadata.

    @JPBergsma
    JPBergsma committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    6fae33d View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Add specifically that meta suffix must not be used other than for met… 

    …adata fields.
    @JPBergsma
    JPBergsma committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    d343a86 View commit details
    Browse the repository at this point in the history

  2. Moved database specific fields to a seperate section and renamed them… 

    … to Database-Provider-Specific fields.
    @JPBergsma
    JPBergsma committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    54b632c View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Code suggestions from Vaitkus.

Co-authored-by: Antanas Vaitkus <[email protected]>
    @JPBergsma @vaitkus
    JPBergsma and vaitkus authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    5d186d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Added 'metadata_for' field.

    @JPBergsma
    JPBergsma committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    cb63bf2 View commit details
    Browse the repository at this point in the history

  2. Revert "Moved database specific fields to a seperate section and rena… 

    …med them to Database-Provider-Specific fields."

This reverts commit 54b632c.
    @JPBergsma
    JPBergsma committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    d0a4e65 View commit details
    Browse the repository at this point in the history

  3. Revert "Add specifically that meta suffix must not be used other than… 

    … for metadata fields."

This reverts commit d343a86.
    @JPBergsma
    JPBergsma committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9e64a3a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'JPBergsma_add_meta' of https://github.com/JPBergsma/OPT… 

    …IMADE into JPBergsma_add_meta

# Conflicts:
#	optimade.rst
    @JPBergsma
    JPBergsma committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    498f1f5 View commit details
    Browse the repository at this point in the history

  5. Moved mention that suffix '_meta' should not be used for regular fiel… 

    …ds to section database-provider-specific-properties.
    @JPBergsma
    JPBergsma committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    6cfe92f View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Add extra single quotes around the '_meta' suffix.

    @JPBergsma
    JPBergsma committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    1414c55 View commit details
    Browse the repository at this point in the history

  2. Added example of a property definition for a metadata field.

    @JPBergsma
    JPBergsma committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    81f2f96 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Update optimade.rst 

    Co-authored-by: Rickard Armiento <[email protected]>
    @JPBergsma @rartino
    JPBergsma and rartino authored May 1, 2023
    Configuration menu
    Copy the full SHA
    b69b0e8 View commit details
    Browse the repository at this point in the history

  2. Clarifined nested meta data fields a bit.

    @JPBergsma
    JPBergsma committed May 1, 2023
    Configuration menu
    Copy the full SHA
    478a572 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'JPBergsma_add_meta' of https://github.com/JPBergsma/OPT… 

    …IMADE into JPBergsma_add_meta
    @JPBergsma
    JPBergsma committed May 1, 2023
    Configuration menu
    Copy the full SHA
    d3b7050 View commit details
    Browse the repository at this point in the history

  4. Placed meta_data_for field in the property definition.

    @JPBergsma
    JPBergsma committed May 1, 2023
    Configuration menu
    Copy the full SHA
    8ed79b5 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Removed property definition metadata_for field as it is now part of t… 

    …he property definition itself.
    @JPBergsma
    JPBergsma committed May 4, 2023
    Configuration menu
    Copy the full SHA
    f1e179c View commit details
    Browse the repository at this point in the history

  2. Added comma to improve readability.

    @JPBergsma
    JPBergsma committed May 4, 2023
    Configuration menu
    Copy the full SHA
    a60eb5c View commit details
    Browse the repository at this point in the history

  3. Added comma to improve readability.

    @JPBergsma
    JPBergsma committed May 4, 2023
    Configuration menu
    Copy the full SHA
    df40172 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'JPBergsma_add_meta' of https://github.com/JPBergsma/OPT… 

    …IMADE into JPBergsma_add_meta
    @JPBergsma
    JPBergsma committed May 4, 2023
    Configuration menu
    Copy the full SHA
    d16e97c View commit details
    Browse the repository at this point in the history

  5. Postponed decision on whether or not nested metadata fields are allowed

    @JPBergsma
    JPBergsma committed May 4, 2023
    Configuration menu
    Copy the full SHA
    1e81988 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Moved the metadata fields to the JSON API per entry meta field as sug… 

    …gested by Rickard in https://github.com/JPBergsma/OPTIMADE/pull/2/files.

Co-authored-by: Rickard Armiento <[email protected]>
    @JPBergsma @rartino
    JPBergsma and rartino committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    6f56a17 View commit details
    Browse the repository at this point in the history

  2. Removed x-optimade-metadata-for from example property declaration as … 

    …the explanation for this field had already been removed by rartino.
    @JPBergsma
    JPBergsma committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    97a0435 View commit details
    Browse the repository at this point in the history

  3. Tried to make it clearer when a server SHOULD return the meta data.

    @JPBergsma
    JPBergsma committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    00a7a08 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. removed extra '.'

    @JPBergsma
    JPBergsma committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    7099a69 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Apply suggestions from review

    @rartino
    rartino authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    09fffea View commit details
    Browse the repository at this point in the history

  2. Fix where metadata properties appear based on discussion

    @rartino
    rartino authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    cceabb5 View commit details
    Browse the repository at this point in the history

  3. Remove the repetition of info about the data->meta field

    @rartino
    rartino authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    45b98b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. Provide an example that is less objectable for metadata

    @rartino
    rartino authored Jun 11, 2023
    Configuration menu
    Copy the full SHA
    b95c465 View commit details
    Browse the repository at this point in the history

  2. Fix examples as requested by workshop

    @rartino
    rartino authored Jun 11, 2023
    Configuration menu
    Copy the full SHA
    134a906 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Andrius Merkys <[email protected]>
    @JPBergsma @merkys
    JPBergsma and merkys authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    078f174 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from review 

    Co-authored-by: Antanas Vaitkus <[email protected]>
    @rartino @vaitkus
    rartino and vaitkus authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    e15aaff View commit details
    Browse the repository at this point in the history

  3. Fix JSON example spelling error

    @rartino
    rartino authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    9c4417f View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Update optimade.rst 

    Add link back to the Metadata_properties section.
    @JPBergsma
    JPBergsma authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    b36c372 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from review 

    Co-authored-by: Johan Bergsma <[email protected]>
    @rartino @JPBergsma
    rartino and JPBergsma authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    cc42d8f View commit details
    Browse the repository at this point in the history

  3. Remove global per-entry metadata properties

    @rartino
    rartino authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    52ad0c0 View commit details
    Browse the repository at this point in the history

  4. Remove ability for per-entry global metadata

    @rartino
    rartino authored Jun 14, 2023
    Configuration menu
    Copy the full SHA
    62f987d View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Apply suggestions from review 

    Co-authored-by: Antanas Vaitkus <[email protected]>
    @rartino @vaitkus
    rartino and vaitkus authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    aaddc82 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Merged upstream develop

    @rartino
    rartino committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    656e1fb View commit details
    Browse the repository at this point in the history

  2. Update optimade.rst

    @merkys
    merkys authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    4feb8e1 View commit details
    Browse the repository at this point in the history

  3. Cleanup trailing whitespace.

    @merkys
    merkys committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    6992038 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from review 

    Co-authored-by: Antanas Vaitkus <[email protected]>
    @rartino @vaitkus
    rartino and vaitkus authored Jun 16, 2023
    Configuration menu
    Copy the full SHA
    6ffe550 View commit details
    Browse the repository at this point in the history