Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial data #467
Partial data #467
Changes from all commits
70f6d9b
9a5a36f
0680b2f
4063e13
1a7230f
14b9e9d
104ed78
9fa3b29
6ec5a11
92e7c12
cc3da46
7a1f684
0245999
06d6444
3e5fa16
7eddd27
3e1f04c
05eacc2
beaaeef
50c355e
7a92260
8f4db09
16d60f6
e109706
34bdf2a
961f5b7
874bd52
7b314af
6faf8db
316df78
b080cf2
bd93804
10bc845
39d9ae5
2a24c1a
9d9e26e
ff5a27c
8ae1928
d8a11cb
11900c5
1b4093e
496b6ca
4d906a2
b6ab3ae
ee4c1e3
1b0d1a6
1b9c607
562d651
498d169
e5e6046
4906c4f
864450d
e574106
336ef21
93ee583
edf4f25
5b13315
2cfe8c0
4e9fb4d
b50d93d
dfc24d4
a0aa533
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not come from PR #463?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to define the meta field here to hold the "partial_data_links" key? Otherwise this PR would be inconsistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I came across another commit which removed part of the definition of the metadata fields. So it looked like you forgot this piece, which is why I mentioned it.
Either both should be in or both should be out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier I indeed removed a segment here that defined the
property_metadata
subkey ofmeta
, which I agree belong better in #463. But, the segment you have marked now defines themeta
superkey we need for thepartial_data_links
subkey.I'm confused over what you are asking for. Are you saying we absolutely should not mention
meta
with a link to 'JSON Response Schema: Common Fields' that definesmeta -> partial_data_links
; despite that with this PR that key is an absolutely vital part of the 'Entry Listing JSON Response Schema'?This comment was marked as outdated.
Sorry, something went wrong.