-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce roles for files related to calculations #523
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: Antanas Vaitkus <[email protected]>
Co-authored-by: Antanas Vaitkus <[email protected]>
Co-authored-by: Antanas Vaitkus <[email protected]>
My first reaction is: doesn't this belong in Edit: I noticed that I had swapped metadata and data in my comment. Sorry for sounding confused. |
My suggestion is to define the inputs/outputs division in metadata of relationships. Since we use them (relationships) to refer to other entries, then I think |
JSON:API's meta of relationships is not something that exists in OPTIMADE outside of the JSON:API response format, so we have to define this "place" where to store this machine readable From a "least surprise" perspective, it makes more sense to me that there is an "input" and an "output" relationship that contains the relationship linkage to inputs and outputs. |
We have discussed this proposal during the workshop and identified a drawback: there is no way to query on relationship metadata, nor now, nor after #524 gets merged in. A possible solution was put forward to use named relationships (now relationships are named after entry types), but this would possibly:
|
During workshop discussions, @giovannipizzi suggested introducing a means to specify how files are related to calculations entries. This PR introduces
meta.role
field to specify whether an attached file is input or output relative to the calculation in question.Furthermore, there was a suggestion to order the related output files in a way to make it easier for automated analysis software to parse the output files in order to identify the code and/or calculation type used. Since it is impossible to define the deterministic orders for all the used codes, the suggestion is to use an arbitrary order where output files most likely to contain the identifying information come first. This way analysis software would encounter the identifying output files earlier and stop before reading in all the output files.