Skip to content

Commit

Permalink
Merge pull request dotnet#19405 from joperezr/FixTestILCPackage
Browse files Browse the repository at this point in the history
Fix testILC package dependency now that we have RID on package name
  • Loading branch information
joperezr authored May 5, 2017
2 parents a1ceee7 + c8b3ee6 commit 583aa59
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
12 changes: 6 additions & 6 deletions dependencies.props
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
<CoreFxCurrentRef>1ec7eb334c406a82a41c020e73ff1717a0e90f92</CoreFxCurrentRef>
<CoreClrCurrentRef>ccf03e3ac9788a503bae623ca6b765224656a586</CoreClrCurrentRef>
<ExternalCurrentRef>1ec7eb334c406a82a41c020e73ff1717a0e90f92</ExternalCurrentRef>
<ProjectNTfsCurrentRef>1ec7eb334c406a82a41c020e73ff1717a0e90f92</ProjectNTfsCurrentRef>
<ProjectNTfsTestILCCurrentRef>1ec7eb334c406a82a41c020e73ff1717a0e90f92</ProjectNTfsTestILCCurrentRef>
<ProjectNTfsCurrentRef>2fec23caa2e720ba53500a8edac9093cf5d8c354</ProjectNTfsCurrentRef>
<ProjectNTfsTestILCCurrentRef>2fec23caa2e720ba53500a8edac9093cf5d8c354</ProjectNTfsTestILCCurrentRef>
<SniCurrentRef>ca04b94304beb477534b4fa0d6080089c21a0284</SniCurrentRef>
<StandardCurrentRef>1ec7eb334c406a82a41c020e73ff1717a0e90f92</StandardCurrentRef>
</PropertyGroup>
Expand All @@ -23,9 +23,9 @@
<CoreFxExpectedPrerelease>preview2-25304-02</CoreFxExpectedPrerelease>
<CoreClrExpectedPrerelease>preview2-25304-02</CoreClrExpectedPrerelease>
<ExternalExpectedPrerelease>beta-25304-00</ExternalExpectedPrerelease>
<ProjectNTfsExpectedPrerelease>beta-25304-01</ProjectNTfsExpectedPrerelease>
<ProjectNTfsTestILCExpectedPrerelease>beta-25304-01</ProjectNTfsTestILCExpectedPrerelease>
<ProjectNTfsTestILCPackageVersion>1.0.0-beta-25304-01</ProjectNTfsTestILCPackageVersion>
<ProjectNTfsExpectedPrerelease>beta-25305-00</ProjectNTfsExpectedPrerelease>
<ProjectNTfsTestILCExpectedPrerelease>beta-25305-00</ProjectNTfsTestILCExpectedPrerelease>
<ProjectNTfsTestILCPackageVersion>1.0.0-beta-25305-00</ProjectNTfsTestILCPackageVersion>
<NETStandardPackageVersion>2.0.0-preview2-25304-01</NETStandardPackageVersion>
<NETStandardPackageId>NETStandard.Library</NETStandardPackageId>
<!-- Use the SNI runtime package -->
Expand Down Expand Up @@ -114,7 +114,7 @@
<XmlUpdateStep Include="ProjectNTfsTestILC">
<Path>$(MSBuildThisFileFullPath)</Path>
<ElementName>ProjectNTfsTestILCPackageVersion</ElementName>
<PackageId>TestILCNugetPackageForCoreFX</PackageId>
<PackageId>TestILC.amd64ret</PackageId>
</XmlUpdateStep>
<XmlUpdateStep Include="Sni">
<Path>$(MSBuildThisFileFullPath)</Path>
Expand Down
5 changes: 4 additions & 1 deletion external/test-runtime/XUnit.Runtime.depproj
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,10 @@
AfterTargets="RestorePackages"
Condition="'$(TargetGroup)' == 'uapaot'">
<PropertyGroup>
<TestILCToolsPackageName>TestILCNugetPackageForCoreFX</TestILCToolsPackageName>
<TestILCToolsPackageName>TestILC</TestILCToolsPackageName>
<TestILCToolsPackageName Condition="'$(ArchGroup)' == 'x64'">$(TestILCToolsPackageName).amd64ret</TestILCToolsPackageName>
<TestILCToolsPackageName Condition="'$(ArchGroup)' == 'x86'">$(TestILCToolsPackageName).x86ret</TestILCToolsPackageName>
<TestILCToolsPackageName Condition="'$(ArchGroup)' == 'arm'">$(TestILCToolsPackageName).armret</TestILCToolsPackageName>
<TestILCFolder Condition="'$(TestILCFolder)' == ''">$(PackagesDir)$(TestILCToolsPackageName)\$(ProjectNTfsTestILCPackageVersion)\TestILC</TestILCFolder>
<TestILCFolder>$(TestILCFolder.Replace('/', '\'))</TestILCFolder>
</PropertyGroup>
Expand Down
4 changes: 3 additions & 1 deletion external/test-runtime/optional.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
"dependencies": {
"Microsoft.DotNet.IBCMerge": "4.6.0-alpha-00001",
"Microsoft.DotNet.UAP.TestTools": "1.0.2",
"TestILCNugetPackageForCoreFX": "1.0.0-beta-25304-01"
"TestILC.amd64ret": "1.0.0-beta-25305-00",
"TestILC.armret": "1.0.0-beta-25305-00",
"TestILC.x86ret": "1.0.0-beta-25305-00"
}
}
}
Expand Down

0 comments on commit 583aa59

Please sign in to comment.