Disabling benchmark due to issue #29308 (dotnet#29309)

- Increasing the timeout on perf.groovy (Running profile and diagnostic runs takes over the default of 4 hours.)
MaximLipnin · Apr 25, 2018 · e4e6873 · e4e6873
1 parent 59cf056
commit e4e6873
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/perf.groovy b/perf.groovy
@@ -95,6 +95,7 @@ def osShortName = ['Windows 10': 'win10',
                         "py \"%WORKSPACE%\\Tools\\Microsoft.BenchView.JSONFormat\\tools\\submission-metadata.py\" --name " + "\"" + benchViewName + "\"" + " --user-email " + "\"[email protected]\"\n" +
                         "py \"%WORKSPACE%\\Tools\\Microsoft.BenchView.JSONFormat\\tools\\build.py\" git --branch %GIT_BRANCH_WITHOUT_ORIGIN% --type " + runType)
                         batchFile("py \"%WORKSPACE%\\Tools\\Microsoft.BenchView.JSONFormat\\tools\\machinedata.py\"")
+
                         batchFile("call \"C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\vcvarsall.bat\" x86 && build-managed.cmd -release -tests -- /p:Performance=true /p:TargetOS=${osGroup} /m:1 /p:LogToBenchview=true /p:BenchviewRunType=${runType} /p:PerformanceType=Profile")
                         batchFile("call \"C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\vcvarsall.bat\" x86 && build-managed.cmd -release -tests -- /p:Performance=true /p:TargetOS=${osGroup} /m:1 /p:LogToBenchview=true /p:BenchviewRunType=${runType} /p:PerformanceType=Diagnostic")
                     }
@@ -114,6 +115,7 @@ def osShortName = ['Windows 10': 'win10',
                         "python3.5 \"\${WORKSPACE}/Tools/Microsoft.BenchView.JSONFormat/tools/submission-metadata.py\" --name " + "\"" + benchViewName + "\"" + " --user-email " + "\"[email protected]\"\n" +
                         "python3.5 \"\${WORKSPACE}/Tools/Microsoft.BenchView.JSONFormat/tools/build.py\" git --branch \$GIT_BRANCH_WITHOUT_ORIGIN --type " + runType)
                         shell("python3.5 \"\${WORKSPACE}/Tools/Microsoft.BenchView.JSONFormat/tools/machinedata.py\"")
+
                         shell("bash ./build-managed.sh -release -tests -- /p:Performance=true /p:TargetOS=${osGroup} /m:1 /p:LogToBenchview=true /p:BenchviewRunType=${runType} /p:PerformanceType=Profile")
                     }
                 }
@@ -143,7 +145,7 @@ def osShortName = ['Windows 10': 'win10',
                 }
                 wrappers {
                     timeout {
-                        absolute(240)
+                        absolute(360)
                     }
                 }
             }

diff --git a/src/System.Net.Http/tests/Performance/Perf.SocketsHttpHandler.cs b/src/System.Net.Http/tests/Performance/Perf.SocketsHttpHandler.cs
@@ -27,7 +27,7 @@ public static IEnumerable<object[]> Get_MemberData() =>
             from responseLength in new[] { 1, 100_000 }
             select new object[] { ssl, connectionPerRequest, chunkedResponse, responseLength };
 
-        [Benchmark(InnerIterationCount = InnerIterationCount)]
+        [Benchmark(InnerIterationCount = InnerIterationCount, Skip = "https://github.com/dotnet/corefx/issues/29308")]
         [MemberData(nameof(Get_MemberData))]
         public async Task Get(bool ssl, bool connectionPerRequest, bool chunkedResponse, int responseLength)
         {
@@ -37,7 +37,7 @@ public async Task Get(bool ssl, bool connectionPerRequest, bool chunkedResponse,
                 #region Server
                 listener.Bind(new IPEndPoint(IPAddress.Loopback, 0));
                 listener.Listen(int.MaxValue);
-                string responseText = 
+                string responseText =
                     "HTTP/1.1 200 OK\r\n" + (connectionPerRequest ? "Connection: close\r\n" : "") + (chunkedResponse ?
                     $"Transfer-Encoding: chunked\r\n\r\n{responseLength.ToString("X")}\r\n{new string('a', responseLength)}\r\n0\r\n\r\n" :
                     $"Content-Length: {responseLength}\r\n\r\n{new string('a', responseLength)}");