Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wgpu to 24 and egui to 0.31 #135

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

raggi
Copy link
Contributor

@raggi raggi commented Feb 9, 2025

I'm playing with embedding into an Iced build, where Iced's shader module only provides &Device and &Queue references. This update provides Device::clone() and Queue::clone() for shallow copies, replacing the Arc wrappers, making this integration signature compatible during renderer setup.

Copy link
Owner

@Maximkaaa Maximkaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It's nice to have an update that doesn't require rewrite of half the code :-).

Please, fix one little nitpick and clippy warnings and I'll merge it in.

@raggi raggi force-pushed the wgpu-bump branch 2 times, most recently from 8ed1ad6 to 5636129 Compare February 10, 2025 07:08
I'm playing with embedding into an Iced build, where Iced's shader
module only provides &Device and &Queue references. This update provides
Device::clone() and Queue::clone() for shallow copies, replacing the Arc
wrappers, making this integration signature compatible during renderer
setup.
@raggi
Copy link
Contributor Author

raggi commented Feb 10, 2025

Thanks for the PR. It's nice to have an update that doesn't require rewrite of half the code :-).

Right! Apologies for stealing an easier one 🤣

Please, fix one little nitpick and clippy warnings and I'll merge it in.

Thanks for the review, and for all this code!

@raggi raggi requested a review from Maximkaaa February 10, 2025 07:17
@Maximkaaa Maximkaaa merged commit 72b063c into Maximkaaa:main Feb 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants