Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSM attribution in the examples that use OSM tiles #128 #155

Merged
merged 5 commits into from
Feb 25, 2025

Conversation

siddheshzz
Copy link
Contributor

Description

  • This PR adds the attribution to the UI
  • OSM & Maptiler will have respective attribution as per their policy

Related Issue

Fixes #128

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please specify):

How to Test

Verified the change on the examples present in galileo/example

Screenshot 2025-02-21 at 10 50 41 AM Screenshot 2025-02-21 at 10 51 25 AM

Copy link
Owner

@Maximkaaa Maximkaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Just a few fixes needed to how the attribution is applied to the map.

Copy link
Owner

@Maximkaaa Maximkaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few minor tweaks and we are good to go.

@Maximkaaa
Copy link
Owner

I think you missed one comment. Let's fix it and merge this PR.

@Maximkaaa Maximkaaa merged commit 1b03e0a into Maximkaaa:main Feb 25, 2025
5 checks passed
@Maximkaaa
Copy link
Owner

Thank you for working it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OSM attribution in the examples that use OSM tiles
2 participants