[Backport 3.6] Align development 3.6 test helpers with ssl helpers and certs.c
#9713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Horstmann <[email protected]>
These necessarily differ from development Signed-off-by: David Horstmann <[email protected]>
In 4.x the semantics of MBEDTLS_PSA_CRYPTO_C and MBEDTLS_PSA_CRYPTO_CLIENT are different compared with 3.6. Where this is a problem, make guards more version-specific so that we are guarding with MBEDTLS_PSA_CRYPTO_C for 3.6 and MBEDTLS_PSA_CRYPTO_CLIENT for 4.x, keeping each branch the same as it was formerly. Signed-off-by: David Horstmann <[email protected]>
In 3.6.0, TLS 1.3 was enabled by default, causing mbedtls_ssl_write() to sometimes return a negative error code MBEDTLS_ERR_SSL_RECEIVED_NEW_SESSION_TICKET. This broke some existing applications. In 3.6.1 this was fixed so that NewSessionTicket messages are now ignored by default and the error-like behaviour has to be explicitly turned on. Our tests rely on this error-like behaviour, so we must explicitly turn it on in 3.6 or else the ssl tests will hang. Signed-off-by: David Horstmann <[email protected]>
Take into account the fact that TLS 1.3 auto-calls psa_crypto_init() Signed-off-by: David Horstmann <[email protected]>
Signed-off-by: David Horstmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full-scope version of #9547, in case it is needed in future.
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.