[Backport 3.6] Fix doc on GCM API #9762
Open
+4,173
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates GCM buffer overlap documentation to explicitly support overlapping encryption/decryption buffers for GCM. Signed-off-by: Harry Ramsey <[email protected]>
This commit adds test cases for input and output buffer overlap. The data for the test cases is a duplicate of existing encrypt/decrypt test cases. The two test functions gcm_<encrypt/decrypt>_input_output_buffer_overlap are modified to use a single malloc buffer rounded to the nearest 128-bits/16-bytes for input and output. Signed-off-by: Harry Ramsey <[email protected]>
Harry-Ramsey
commented
Nov 7, 2024
| if (buffer_len % 16 != 0) { | ||
| buffer_len += (16 - (buffer_len % 16)); | ||
| } | ||
| TEST_CALLOC(buffer, buffer_len); |
There was a problem hiding this comment.
Regarding test faliures, can TEST_CALLOC not be used in 3.6?
There was a problem hiding this comment.
TEST_CALLOC is available and (should be) identical in all supported branches.
You don't need if NULL goto exit: that's built into the macro. Furthermore, buffer will actually be null on success when buffer_len == 0. That may be the cause of the CI failures? It would be the same in development though.
Harry-Ramsey
added
needs-ci
This commit fixes issues with TEST_CALLOC in GCM buffer overlap tests cases. Signed-off-by: Harry Ramsey <[email protected]>
This commit fixes an issue with check_names failing due to not being defined as a macro in Mbed TLS. This is instead defined by alternative implementations of MBEDTLS_GCM. Signed-off-by: Harry Ramsey <[email protected]>
This commit fixes an issue in the GCM shared buffer test case where input data could be of length 0 and an adequate buffer was not allocated. Signed-off-by: Harry Ramsey <[email protected]>
This was referenced Nov 13, 2024
Harry-Ramsey
added
needs-review
davidhorstmann-arm
requested changes
Nov 13, 2024
This commit fixes documentation specifying buffer overlap on GCM decryption functions. Signed-off-by: Harry Ramsey <[email protected]>
eleuzi01
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #7977.
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: