Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MBEDTLS_PSA_CRYPTO_CONFIG configuration option #9771

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Remove MBEDTLS_PSA_CRYPTO_CONFIG configuration option #9771

wants to merge 3 commits into from

Conversation

ronald-cron-arm
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm commented Nov 12, 2024 •
edited
Loading

Description

Fixes #9622

PR checklist

@ronald-cron-arm ronald-cron-arm added enhancement needs-ci Needs to pass CI tests priority-high High priority - will be reviewed soon needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Nov 12, 2024
@minosgalanakis
Copy link
Contributor

Is this PR intended to remove only the configuration options, or the source code that is enabled by it?

Should we consider adjusting the ext configration files?

@ronald-cron-arm
Copy link
Contributor Author

ronald-cron-arm commented Nov 14, 2024 •
edited
Loading

Is this PR intended to remove only the configuration options, or the source code that is enabled by it?

Both.

Should we consider adjusting the ext configration files?

I have on purpose not changed these ones as they are not supposed to be changed, just imported from TF-M project.

@ronald-cron-arm ronald-cron-arm mentioned this pull request Nov 14, 2024
Closed
Harry-Ramsey
Harry-Ramsey previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@Harry-Ramsey Harry-Ramsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronald-cron-arm ronald-cron-arm removed the needs-reviewer This PR needs someone to pick it up for review label Nov 14, 2024
@ronald-cron-arm
Update framework
e5ef871 
Signed-off-by: Ronald Cron <[email protected]>
@ronald-cron-arm ronald-cron-arm mentioned this pull request Nov 15, 2024
Open
@ronald-cron-arm ronald-cron-arm added needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members, labels Nov 15, 2024
minosgalanakis
minosgalanakis approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minosgalanakis minosgalanakis minosgalanakis approved these changes

@Harry-Ramsey Harry-Ramsey Harry-Ramsey left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement needs-ci Needs to pass CI tests priority-high High priority - will be reviewed soon
Projects
Mbed TLS Epics
Status: Configuration split
Roadmap pull requests (new board)
Status: In Development
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove MBEDTLS_PSA_CRYPTO_CONFIG configuration option
3 participants
@ronald-cron-arm @minosgalanakis @Harry-Ramsey