Remove redundant locators and clean-up leftover pre-modules code #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up leftover code from before the module era that is no longer functional in modern modlauncher versions which make use of modules.
The reason for skipping a deprecation phase is that said code is no longer used by modlauncher itself and does nothing on its own, whereas deprecated code would still be considered functional. There is no reason for us to keep this code. It's outdated and should be removed immediately to avoid confusing users.
Additional class/resource locators
Removes 2 unused locator methods in
ITransformationService
:additionalClassesLocator
additionalResourcesLocator
These methods have not had any effect since modlauncher 9+. With the module system in place, all classes and resources must be associated with a source module, and thus anonymous providers are no longer viable. Instead, modders are encouraged to use the scan callback methods (
beginScanning
,completeScan
) to load additional jars at runtime.TransformingClassLoaderBuilder
The
TransformingClassLoaderBuilder
class was previously used to create a customized classloader instance with extra transformable paths or a class byte provider function. Both of these are no longer used by modlauncher, as the module layers are immutable and cannot be expanded. The transforming class loader pulls all of its data from theGAME
module layer.Fixes #89
Fixes #111