Modify class reader flags in class transformer #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs says:
How much is "a lot". |
marchermans
approved these changes
Apr 24, 2024
|
It is breaking, yeah. We'll need to make sure to bump mixin alongside modlauncher next time we do so. |
marchermans
added a commit
that referenced
this pull request
Apr 25, 2024
…)" This reverts commit f1f25dc.
marchermans
pushed a commit
that referenced
this pull request
Apr 25, 2024
Relates to neoforged/NeoForge#768 (cherry picked from commit f1f25dc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the flags used to read
ClassNodes inClassTransformerfrom0toClassReader.EXPAND_FRAMES. This ensures the correctness of local variable analysis, while also achieving parity with Fabric's flag usage (which is currently the inverse of modlauncher's settings).modlauncher/src/main/java/cpw/mods/modlauncher/ClassTransformer.java
Line 76 in 26f7226
For a complete description of the issue, please see neoforged/NeoForge#768