Keep uwsgi plugin from crashing the agent #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uwsgi plugin sometimes receives truncated data back from the uwsgi stats server. When this happens, json.loads() fails to process the data, and throws an exception. This bubbled up all the way to the main python process and halted the agent. IMO, this should not be an agent-killing problem. Wrapping json.loads() with a try-except block and giving it some default behavior keeps it from exploding when it recieves bad data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uwsgi plugin sometimes receives truncated data back from the uwsgi
stats server. When this happens, json.loads() fails to process the
data, and throws an exception. This bubbled up all the way to the
main python process and halted the agent.
IMO, this should not be an agent-killing problem. Wrapping json.loads()
with a try-except block and giving it some default behavior keeps it
from exploding when it recieves bad data.