Feature/editable routing tables #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acking - Implemented editable fields for routing table entries, allowing users to modify IP, mask, and interface values directly. - Introduced a 'manuallyEdited' flag in each routing table entry to track manual modifications and prevent them from being overwritten during table regeneration. - Modified the regenerateRoutingTable function to retain manually edited entries while updating only non-modified ones. Currently, only changes to the 'interface' column have an effect, while modifications to the IP and mask columns do not affect the logic yet.
- Added a focus check to prevent shortcut execution when the user is typing in input or textarea fields.
… on invalid input
…d manual entry issues - Implemented persistence for routing tables to ensure they are saved and restored correctly. - Fixed the undo functionality for RemoveDevice to properly restore device connections and routing tables. - Resolved issues related to manually edited routing table entries: - Ensured manually edited entries are retained only if the corresponding connection exists. - Fixed overwriting issues caused by index-based management by switching to IP-based matching. - Improved consistency when regenerating routing tables after topology changes. These improvements enhance the stability and accuracy of the routing table management system.
Manuel-Pol
approved these changes
Jan 23, 2025
Refactored the logic for preserving manually edited entries in the routing table. The previous implementation conditionally added entries to the new table if they were still connected. The updated logic now only updates existing entries and logs a warning if no matching entry is found, preventing unintended additions and ensuring data consistency.
Implemented logic to store and restore routing tables when a device is removed and then restored. Now, when a router is deleted, its routing table, along with the routing tables of connected devices, is saved. During an undo operation, the device and its connections are restored, ensuring that all routing tables are reinstated correctly.
Improved the user interface by implementing a popup modal for cell editing. Now, when a cell is clicked, a modal appears allowing users to edit values with validation and a better user experience. The modal is positioned next to the right sidebar for better accessibility.
- Added functionality to refresh the routing table. - Added support for row deletion, ensuring both UI and data are updated. - Integrated event listeners for handling table updates and row removal.
## 📌 Main Changes: ### 🛠 Refactored Routing Table Regeneration: - Created a `generateRoutingTable(id, preserveEdits)` function to eliminate duplicated code in `regenerateRoutingTableClean` and `regenerateRoutingTable`. - `generateRoutingTable` now handles route generation, and if `preserveEdits = true`, it preserves manually edited and deleted entries. - Improved code clarity with a cleaner and more reusable structure. ### 🎨 Improved Editable UI in Routing Table: - Removed the modal, making table cells directly editable (`contentEditable = "true"`). - Added column-based validation before saving changes: - **IP** → Ensures valid IP format. - **Subnet Mask** → Validates correct subnet mask values. - **Interface** → Only allows values in the `ethX` format. - If an invalid value is entered, it is reverted to the previous one, and a warning is displayed in the console. ### ⌨️ Keyboard Shortcut Handling: - Added a `keydown` event listener to prevent `Delete` or `Backspace` from triggering the shortcut for removing a device when editing a cell. ✅ **Results**: - More modular and reusable code. - Improved user experience when editing the table. - Easier maintenance for route generation logic. 🚀 Ready for testing and future enhancements!
MegaRedHand
reviewed
Feb 1, 2025
Comment on lines
+59
to
+60
| connections: DeviceId[], | ||
| viewgraph: ViewGraph, // Pasamos la vista para obtener las tablas de enrutamiento |
There was a problem hiding this comment.
We shouldn't need to do this anymore. I previously refactored CreateDevice to store the node data from the datagraph, so if the data is in the datagraph, CreateDevice has it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routing Table Editing:
Persistence Improvements:
Undo/Redo Enhancements:
TODO: Evaluate alternative UI approaches for routing table editing to improve user experience.
closes #73