Undo redo bugs #118
Merged
Undo redo bugs #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layers takes the user back to the layer. Main Advantages: - Now devices don’t appear in layer where are not suposed to appear. - Undo/Redo moves are more ex plicit for user
Bug: - When redoing a RemoveDevice move the deviceData store for the redo move was passed to the datagraph as the graphNode of the device. Consequently, as the RemoveDeviceMove object and the datagraph shared the same node reference, when the datagraph modify the node it was also modify in the RemoveDeviceMove object, which lead to inconsistencies in it state.
pgallino
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.