Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Wood types with birch in the name not generating shelf model #31

Merged

Conversation

VoidLeech
Copy link
Contributor

Fixes #30
Renames Supplementaries's Item Shelf to Oak Item Shelf matching the new shelves.

Replaces "birch" with "suppsquared_shelf" for the dynamic asset generation. Don't think there will ever be a mod containing that in a wood type or its mod id (:

Lmk whether you'd like a pr for 1.21.1 as well or whether you've got that yourself.

@MehVahdJukaar
Copy link
Owner

thanks, i didnt see this

@MehVahdJukaar MehVahdJukaar merged commit d3459ea into MehVahdJukaar:1.20 Feb 16, 2025
@VoidLeech VoidLeech deleted the 1.20.1/fix-models-with-birch branch February 17, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compat: Silver Birch Item Shelf fails to generate model.
2 participants