Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sim ux change #225

Merged
merged 7 commits into from
Feb 21, 2021
Merged

Sim ux change #225

merged 7 commits into from
Feb 21, 2021

Conversation

glipR
Copy link
Contributor

@glipR glipR commented Feb 19, 2021

Removes user defined sim files. Moves soccer and rescue to the main screen. Some more user-proofing when it comes to selecting bots for sims.

@glipR
Copy link
Contributor Author

glipR commented Feb 19, 2021

This is probably the biggest change when it comes to sim usability. Can already tell this will be much easier.

@glipR glipR requested a review from jtbui20 February 19, 2021 06:17
@glipR
Copy link
Contributor Author

glipR commented Feb 19, 2021

lmk if this is kind of the idea you also had for the menus @jtbui20 . Still also need to redesign the bot picker as it currently isn't great / requires more clicks than it should.

@jtbui20
Copy link
Contributor

jtbui20 commented Feb 19, 2021

That's mainly in line with what I have on my draft, but I'm probably looking to condense the options / bot select screens into one.
I feel like an immediate quick start doesn't feel right (going straight from home -> field) unless there would only be one combination of robots that a person would use. Going from home -> options + bots -> field) with a quick way to go to the field would be preferable as a means of a "confirmation message" that yes, you do want these bots and yes, these are the right rules. E.g. on keyboard controls you'd just "mash space", similar to mashing next on installation prompts and whatnot; there's an opportunity to double check but if you REALLY don't mind then you'd just move on quickly.

@glipR
Copy link
Contributor Author

glipR commented Feb 19, 2021

Fair enough, I had that in mind too but didn't want to overhaul the settings and bot select page just yet.

The settings themselves aren't too important and so can probably scroll below the bot selection page, I don't think its wise to try to fit them all on screen at once. Either that or a tab at the top to switch between settings and bot selection (With bot selection being the default landing tab)

@glipR
Copy link
Contributor Author

glipR commented Feb 20, 2021

(Fixes #210)

Copy link
Member

@peter-drew peter-drew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot better

@glipR glipR merged commit f79d274 into main Feb 21, 2021
@glipR glipR deleted the sim_ux_change branch February 21, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants