feat: scylladb database provider implementation #320
+568
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Daniel-Boll
reviewed
Nov 5, 2024
mykaul
reviewed
Nov 5, 2024
cmd/program/program.go
Outdated
| @@ -103,6 +103,7 @@ var ( | |||
| sqliteDriver = []string{"github.com/mattn/go-sqlite3"} | |||
| redisDriver = []string{"github.com/redis/go-redis/v9"} | |||
| mongoDriver = []string{"go.mongodb.org/mongo-driver"} | |||
| scyllaDriver = []string{"github.com/gocql/gocql"} | |||
There was a problem hiding this comment.
Suggested change
| scyllaDriver = []string{"github.com/gocql/gocql"} | |
| scyllaDriver = []string{"github.com/scylladb/gocql"} |
There was a problem hiding this comment.
Since we have to replace the module, I managed to add a GoCQL driver and then a a replaceable right after it.
Should be clean enough for now.
mykaul
reviewed
Nov 5, 2024
mykaul
reviewed
Nov 5, 2024
mykaul
reviewed
Nov 5, 2024
| "strings" | ||
| "time" | ||
|
|
||
| "github.com/gocql/gocql" |
There was a problem hiding this comment.
I do believe it should also be https://github.com/scylladb/gocql
There was a problem hiding this comment.
Nope, our gocql driver is not there yet.
There was a problem hiding this comment.
AFAIK we have to replace one module for another.
Check Gemini go.mod for a reference.
dkropachev
reviewed
Nov 5, 2024
| "strings" | ||
| "time" | ||
|
|
||
| "github.com/gocql/gocql" |
There was a problem hiding this comment.
Nope, our gocql driver is not there yet.
Co-authored-by: Yaniv Kaul <[email protected]>
Co-authored-by: Dmitry Kropachev <[email protected]>
|
Ready to review @Melkeydev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
Feature
This pull request introduces support for ScyllaDB as a new database option in the project. It includes modifications to various parts of the codebase to integrate ScyllaDB, including database drivers, templates, and Docker configurations.
Description of Changes:
go mod edithelper to get the updated driverChecklist