Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile.am, configure.ac: fix hard coded static and include path #1026

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Makefile.am, configure.ac: fix hard coded static and include path #1026

wants to merge 8 commits into from

Commits on Nov 14, 2024

  1. Makefile.am: fix static link, drop LDFLAGS static 

    I do not understand why some -static are enforced while dynamic
linkage could be used.

We should not have any -static in order to be able to link
for the targets.
    @vjardin
    vjardin committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b588c7e View commit details
    Browse the repository at this point in the history

  2. libxml2: do not enforce isystem path 

    It is not compliant with cross compilation, it will lead to the
following:

aarch64-buildroot-linux-gnu-g++ -c -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O2 -g0 -D_FORTIFY_SOURCE=1 -DHAVE_TERMIOS_H -DHAVE_SYS_PCI_H -isystem /usr/include/libxml2 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 conftest.cpp
aarch64-buildroot-linux-gnu-g++: ERROR: unsafe header/library path used in cross-compilation: '-isystem' '/usr/include/libxml2'

configure.ac: proper probe libxml2

libxml2: CFLAGS and CXXFLAGS are used
Makefiles are not using xml_CFLAGS
    @vjardin
    vjardin committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    46579bf View commit details
    Browse the repository at this point in the history

  3. configure.ac: libcurl patch 

    the include path cannot be hardcoded with:
  /usr/include/curl/
    @vjardin
    vjardin committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    01209d5 View commit details
    Browse the repository at this point in the history

  4. openssl: add missing engine.h 

    engine is exported by openssl/engine.h ; if not, we can have some
compilation warnings of some undefined symbols.
    @vjardin
    vjardin committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9990de4 View commit details
    Browse the repository at this point in the history

  5. configure.ac: explicit BUILD_DYNAMIC for Makefiles 

    Thanks to this definition, we'll be able to ave cleaner Makefiles.
    @vjardin
    vjardin committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ddafc9f View commit details
    Browse the repository at this point in the history

  6. libmtcr_ul: drop install-exec-hook 

    the .so file should remain for the target when dynamic linkage is used.
If the file is removed, none of the applications will be loadable.
    @vjardin
    vjardin committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3d6032e View commit details
    Browse the repository at this point in the history

  7. Makefile.am: dynamic vs static 

    start using DYNAMIC in order to be aligned with the
  --enable-all-static
argument.
    @vjardin
    vjardin committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    cbc9640 View commit details
    Browse the repository at this point in the history

  8. libmtcr_ul.so missing for DPDK 

    DPDK assumes that the library shall be into /usr/lib instead of /usr/lib/mstflint/
    @vjardin
    vjardin committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7f5822c View commit details
    Browse the repository at this point in the history