refactor: use click #534
Merged
refactor: use click #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2024
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Changelog requirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
|
sileht
force-pushed
the
devs/sileht/merged-handling/Ic4dee15f244a08330482808942e0e0d9a9901dc6
branch
from
8d40edd
to
741d703
Compare
sileht
force-pushed
the
devs/sileht/merged-handling/I0819ea54489367dcfeb52a70c5257edc7d3d5c14
branch
from
dfc548c
to
2bd3725
Compare
sileht
force-pushed
the
devs/sileht/merged-handling/I0819ea54489367dcfeb52a70c5257edc7d3d5c14
branch
from
2bd3725
to
1bdf3db
Compare
|
What's the advantage of click over argparse ? |
Syffe
previously approved these changes
Nov 4, 2024
sileht
force-pushed
the
devs/sileht/merged-handling/Ic4dee15f244a08330482808942e0e0d9a9901dc6
branch
from
741d703
to
fa84d92
Compare
sileht
force-pushed
the
devs/sileht/merged-handling/I0819ea54489367dcfeb52a70c5257edc7d3d5c14
branch
from
1bdf3db
to
7b9eb33
Compare
sileht
force-pushed
the
devs/sileht/merged-handling/Ic4dee15f244a08330482808942e0e0d9a9901dc6
branch
from
fa84d92
to
6bd1a05
Compare
sileht
force-pushed
the
devs/sileht/merged-handling/I0819ea54489367dcfeb52a70c5257edc7d3d5c14
branch
from
7b9eb33
to
3592925
Compare
sileht
force-pushed
the
devs/sileht/merged-handling/Ic4dee15f244a08330482808942e0e0d9a9901dc6
branch
from
6bd1a05
to
ec29a85
Compare
sileht
force-pushed
the
devs/sileht/merged-handling/I0819ea54489367dcfeb52a70c5257edc7d3d5c14
branch
from
3592925
to
c058501
Compare
sileht
force-pushed
the
devs/sileht/merged-handling/Ic4dee15f244a08330482808942e0e0d9a9901dc6
branch
from
ec29a85
to
9062980
Compare
sileht
force-pushed
the
devs/sileht/merged-handling/I0819ea54489367dcfeb52a70c5257edc7d3d5c14
branch
from
c058501
to
2a0f4fe
Compare
Syffe
previously approved these changes
Nov 8, 2024
sileht
force-pushed
the
devs/sileht/merged-handling/Ic4dee15f244a08330482808942e0e0d9a9901dc6
branch
from
9062980
to
efd00cc
Compare
sileht
force-pushed
the
devs/sileht/merged-handling/I0819ea54489367dcfeb52a70c5257edc7d3d5c14
branch
from
2a0f4fe
to
e4da612
Compare
Base automatically changed from
devs/sileht/merged-handling/Ic4dee15f244a08330482808942e0e0d9a9901dc6
to
main
November 13, 2024 08:51
|
@sileht this pull request is now in conflict 😩 |
lecrepont01
previously approved these changes
Nov 13, 2024
sileht
force-pushed
the
devs/sileht/merged-handling/I0819ea54489367dcfeb52a70c5257edc7d3d5c14
branch
from
e4da612
to
48b73d2
Compare
mergify
bot
dismissed
lecrepont01’s stale review
Pull request has been modified.
This introduces a CLI interface breakage, due to how click work This does not work anymore $ mergify stack push --token foobar Token (and other global args) are to be passed like this: $ mergify --token foobar stack push Change-Id: I0819ea54489367dcfeb52a70c5257edc7d3d5c14
sileht
force-pushed
the
devs/sileht/merged-handling/I0819ea54489367dcfeb52a70c5257edc7d3d5c14
branch
from
48b73d2
to
f5256b1
Compare
Syffe
approved these changes
Nov 14, 2024
mergify
bot
deleted the
devs/sileht/merged-handling/I0819ea54489367dcfeb52a70c5257edc7d3d5c14
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a CLI interface breakage, due to how click work
This does not work anymore
$ mergify stack push --token foobar
Token (and other global args) are to be passed like this:
$ mergify --token foobar stack push