-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split HTML and binary #17
base: master
Are you sure you want to change the base?
Conversation
I could not fix the rotation animation after the fifth rotation, as it seems to be done not on purpose. |
Any thoughts or wishes? |
I wanted to decide on an embedding tool and then do the changes myself, but I didn't get around to it yet (as you might have noticed, I'm not super disciplined as far as working on this project is concerned :) ). |
Thanks for the feedback.
Well my thought on this was, that development can be split up more easily, enabling some html+css wizards (their is a certain commentar about css in the source file ;) ), to do their stuff and hence, get some more people involved. Furthermore, different people might have different needs and the easiest would be to enable them to select which file they would like to serve.
Well, as I said, I am a complete Go beginner. I simply used what I figured out first.
Again, I just found a lot of examples that did it that way. I thought if the program can't find the file it would be right to terminate the program.
Definitely agree, credits go where credits belong. In the issue #4 , was some good start, but finally no movement. I used #4 to create my own version a while ago with all the whistles and bells, including the zoom by mouse. I added the splitting of the files as this enabled me to tinker with the html and the css part without the need to recompile everything over and over. Thus, I thought I go the extra mile and give it back to the community and see how it goes.
Another, I never used go before thing, it includes I never heard of gofmt before ;) Will look into it.
My life is not depending on this PR either, as my own private version works for me. I took this as an academic adventure and excuse to delve into Go and see how it goes ;) It furthermore creates noise on github, pushing people into believing that this project is not dead ;) |
In addition, I refactored the html code as requested.
It requires now to copy both files (bin and html) to the reMarkable.