Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mambaforge warning #484

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Fix mambaforge warning #484

merged 2 commits into from
Nov 11, 2024

Conversation

currocam
Copy link
Contributor

Currently, we get in the unix CI the following warning:

"'Mambaforge' variants are now equivalent to 'Miniforge3'. In the future, we will ignore with a warning and use 'Miniforge3'. Eventually, using 'Mambaforge' will throw an error. Please change to 'Miniforge3' at your earliest convenience."

https://conda-forge.org/news/2024/07/29/sunsetting-mambaforge/

This PR (to merge after CI in windows is fixed) moves to "miniforge" and replaces "mamba" with "conda" for consistency

@bhaller
Copy link
Contributor

bhaller commented Nov 11, 2024

Hi @currocam! OK, I just merged #483. Now this is a followup change you also want me to merge? At present it is a draft; let me know when it should go in. Thanks!

@currocam currocam marked this pull request as ready for review November 11, 2024 17:29
@currocam
Copy link
Contributor Author

Yes! If all test pass, then I'm happy with this PR.

@bhaller bhaller merged commit 6e77cf4 into MesserLab:master Nov 11, 2024
18 checks passed
@bhaller
Copy link
Contributor

bhaller commented Nov 11, 2024

Great, thank you so much @currocam! Your help with this type of issue is really invaluable. :->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants