Migrate or remove old repository unit tests #296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to changes to system design.
MatthewHambley
changed the title
| assert process.returncode == -15 | ||
|
|
||
| @mark.skip(reason="Too hard to test at the moment.") | ||
| def test_extract_from_http(self, workspace, tmp_path: Path): |
There was a problem hiding this comment.
Should workspace have a type hint here?
|
|
||
| @mark.skipif(not find_executable('git-daemon'), | ||
| reason="Unable to find git daemon") | ||
| def test_extract_from_git(self, workspace, tmp_path: Path): |
There was a problem hiding this comment.
Should workspace have a type hint here?
| from fab.build_config import BuildConfig | ||
| from fab.steps.grab.svn import split_repo_url, svn_export | ||
|
|
||
| from .support import Workspace, file_tree_compare | ||
|
|
||
|
|
||
| class TestRevision(object): |
There was a problem hiding this comment.
object argument is obsolete in python3
| from pathlib import Path | ||
| from subprocess import Popen, run | ||
| import time | ||
| from typing import Tuple |
There was a problem hiding this comment.
This file is missing a few type hints from new methods. Specifically for TempPathFactory (which would need an additional import) and Workspace
|
This chnage has become totally unwieldy with all the style fixes. I'm shuttting it down so the repository migration can happen and I'll start again from scratch with separate changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salvage some value from the technology demonstrator implementation, unit test wise. Also some minor type hinting, documentation and trying to work out what any of this stuff does. This change only covers repository access unit tests.