3 better compiler support #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`pytest tests` at source directory
Minor documentation update for #277.
278 absolute paths in compilation
…ed, as reported by CI pipeline on Github
#5 Fix test warnings
|
Thanks a lot for the review. I believe I have addressed most issues. Outstanding:
I believe there might be another issue or two that I should mentioned here, but I believe I have comments on all your feedback, so it will be in mu answers. I've opened a few tickets (#311, #312, #313, #314) to keep track of follow-up work. Thanks for the review |
MatthewHambley
requested changes
Jun 19, 2024
source/fab/tools/versioning.py
Outdated
Comment on lines
43
to
54
| def is_working_copy(self, path: Union[str, Path]) -> bool: | ||
| """:returns: whether the given path is a working copy or not. It | ||
| runs the command specific to the instance. | ||
|
|
||
| :param path: directory to be checked. | ||
| """ | ||
| try: | ||
| self.run([self._working_copy_command], cwd=path, | ||
| capture_output=False) | ||
| except RuntimeError: | ||
| return False | ||
| return True |
There was a problem hiding this comment.
Lets have it out and reduce this size of this change by a few lines.
|
OK, I believe I have addressed all issues, and as you suggested I closed all conversations where I think we have agreed :) I left a few things open where I think you should provide feedback to confirm :) |
MatthewHambley
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the big one - it introduces
Toolas baseclass for anything called via subprocess (and removedrun_commandtherefore). It introduces the ToolRepository and ToolBox. Best to read the documentation (atm site-specific-configuration.rst).Note that this is not really complete, outstanding issues are support for compiler-specific flags, better support for linking, handling openmp (so that we can trigger fparser's OMP sentinel handling instead of using a work around).
We did fix up the run_configs, but they won't really work better than before (as in, still hard-coded compiler etc). Once we have a fully working LFRic build system (including the above todos), we will update all the run configs.