More linker wrapper improvements #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly never checked if the wrapped compiler actually exists, it only checked the linker).
…s returned, see issue #379.
jasonjunweilyu
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Hi @hiker , I just finished my review with two questions about querying the openmp flags. Then I think it is ready to be merged. This is indeed a better way of setting up the linker wrapper, as it would clearly notify the user early if the linker related compiler is not working when only the linker is using a wrapper (e.g. linker is mpif90-ifort, compiler is ifort).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure linkers will test if the corresponding compiler actually exists (plus a minor bug fix).