Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-design of playbooks #1652

Merged
merged 13 commits into from
Jan 8, 2024
Merged

Re-design of playbooks #1652

merged 13 commits into from
Jan 8, 2024

Conversation

vidvidvid
Copy link
Collaborator

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
the-game-web ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2024 3:37am

@vidvidvid vidvidvid changed the title Wip re-design of playbooks Re-design of playbooks Dec 4, 2023
@github-actions github-actions bot temporarily deployed to Test-PR-1652 December 4, 2023 14:13 Destroyed
@peth-yursick
Copy link
Member

I can't see if the design was applied to all 3, so thought I should point that out just in case - since "paths", "playbooks" & "great houses" are all "academy" now - this design should apply to all 3.

Also reminds me of the links:

While doing that, might also make sense to move them together.
Right now we got:
Playbooks - metagame.wtf/learn/playbooks/meme-driven-organizations
Great houses - metagame.wtf/learn/great-houses/house-of-ethereum
Paths - metagame.wtf/play/paths/engaged-octos-path

Should all be:
Playbooks - metagame.wtf/academy/meme-driven-organizations
Great houses - metagame.wtf/academy/house-of-ethereum
Paths - metagame.wtf/academy/engaged-octos-path

In short, all of these:
/learn/playbooks/
/learn/great-houses/
/play/paths/
Should be replaced with just: /academy/

Depending on how much additional work this requires, we can make it into a new issue, up to you.

@peth-yursick
Copy link
Member

peth-yursick commented Dec 10, 2023 •
edited by vidvidvid
Loading

Alright, to recap:

  • mobile, guess you knew that but just in case
  • submit button button not the same color as connect & other buttons
  • top slot in the sidebar has rounded corners, should be straight like others
  • need to apply this design to paths & great houses as well
  • (optional) move playbooks, great houses & paths from /learn/playbooks/, /learn/great-houses/ & /play/paths/ to just: /academy/
  • (this would also fix the paths being broken)
  • currently, the top item on the sidebar has round corners & all others have straight. The topmost should have round top corners & bottomost should have round bottom corners, others are straight

@github-actions github-actions bot temporarily deployed to Test-PR-1652 December 12, 2023 11:14 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1652 December 13, 2023 16:48 Destroyed
@vidvidvid vidvidvid marked this pull request as ready for review December 13, 2023 16:52
@github-actions github-actions bot temporarily deployed to Test-PR-1652 December 14, 2023 14:00 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1652 January 1, 2024 10:15 Destroyed
0xSero
0xSero requested changes Jan 1, 2024
View reviewed changes
packages/web/components/QuestChain/UploadProof.tsx
onOpen();
if (!chainId || chainId !== questChain.chainId || !provider) {
addToast({
description: `Wrong Chain, please switch to ${
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're handling 3 separate cases and the description only covers 1, maybe change the description to something like: "Please ensure your wallet is connected to the x chain."

@github-actions github-actions bot temporarily deployed to Test-PR-1652 January 3, 2024 11:18 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1652 January 3, 2024 12:50 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1652 January 4, 2024 09:54 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1652 January 5, 2024 14:50 Destroyed
@github-actions github-actions bot temporarily deployed to Test-PR-1652 January 6, 2024 10:48 Destroyed
@alalonde alalonde force-pushed the feat/playbook-updates branch from 90a96b1 to 51f0237 Compare January 7, 2024 03:37
@0xSero 0xSero merged commit 93145e8 into develop Jan 8, 2024
21 checks passed
@0xSero 0xSero deleted the feat/playbook-updates branch January 8, 2024 13:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

Successfully undeployed the Preview of this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xSero 0xSero 0xSero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vidvidvid @peth-yursick @0xSero