This repository has been archived by the owner on Jan 16, 2025. It is now read-only.
Live Demo build fix: Update to react-scripts 2.x.x #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Live Demo GitHub Pages, linked from the README, does not work and simply gives users a blank page with a deprecated API notice (#28).
The actual code, if run locally, works fine, so it seems that the
gh-pagesbranch which deploys the Live Demo is simply using an old build which depends on the deprecatedweb3window object injection.This PR simply updates
react-scriptsto version 2 from version 1 to fix some code minification errors during build, and allows to deploy the Live Demo with the updated code by running deploy script.@danfinlay I can see you have made all the commits to the
gh-pagesbranch. If this was done by manually building and committing up to that branch, do you want me to create a new build and make a PR for the other branch as well? Let me know.