Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node.js <18.18, 21 #66

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Dec 17, 2024

This drops support for EOL Node.js versions. Required to bump @metamask/utils to the latest version.

I had to make some changes to Playwright to support ubuntu-latest in CI as well.

@Mrtenz Mrtenz requested a review from a team as a code owner December 17, 2024 11:06
Copy link

socket-security bot commented Dec 17, 2024

Copy link

socket-security bot commented Dec 17, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Mrtenz
Copy link
Member Author

Mrtenz commented Dec 17, 2024

@SocketSecurity ignore npm/[email protected]

Network access is ok.

@Mrtenz Mrtenz merged commit 0b66f9b into main Dec 17, 2024
18 checks passed
@Mrtenz Mrtenz deleted the mrtenz/drop-nodejs-16-support branch December 17, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants