Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 299.0.0 #5318

Merged
merged 53 commits into from
Feb 14, 2025
Merged

Release 299.0.0 #5318

merged 53 commits into from
Feb 14, 2025

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Feb 13, 2025

Explanation

This is a controller release that includes the first version of the MultichainNetworkController, which also include AccountController updates. The other version bumps are related to updating their peer dependency version of accounts controller.

References

Related to: #804

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Cal-L Cal-L requested review from a team as code owners February 13, 2025 00:53
Copy link

socket-security bot commented Feb 13, 2025

@Cal-L Cal-L marked this pull request as draft February 13, 2025 01:05
@Cal-L Cal-L marked this pull request as ready for review February 14, 2025 00:41
@Cal-L Cal-L requested a review from a team as a code owner February 14, 2025 01:54
@@ -73,9 +73,9 @@
"typescript": "~5.2.2"
},
"peerDependencies": {
"@metamask/accounts-controller": "^23.0.0",
"@metamask/accounts-controller": "^24.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accounts controller bump will not affect bridge controller

Copy link
Contributor

@cryptodev-2s cryptodev-2s Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we add at least the changelog entry for this bump under unreleased section

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely! Lemme add that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"@metamask/network-controller": "^22.0.0",
"@metamask/transaction-controller": "^45.0.0"
"@metamask/transaction-controller": "^46.0.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transaction controller bump caused by accounts-controller peer dep bump. Also shouldn't affect bridge controller

Copy link
Contributor

@cryptodev-2s cryptodev-2s Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we add at least the changelog entry for this bump under unreleased section

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely! Lemme add that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccharly ccharly changed the title Release/299.0.0 Release 299.0.0 Feb 14, 2025
Co-authored-by: cryptodev-2s <[email protected]>
packages/accounts-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/user-operation-controller/package.json Outdated Show resolved Hide resolved
packages/user-operation-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/multichain-network-controller/CHANGELOG.md Outdated Show resolved Hide resolved
"@metamask/network-controller": "^22.0.0",
"@metamask/transaction-controller": "^45.0.0"
"@metamask/transaction-controller": "^46.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely! Lemme add that.

@@ -73,9 +73,9 @@
"typescript": "~5.2.2"
},
"peerDependencies": {
"@metamask/accounts-controller": "^23.0.0",
"@metamask/accounts-controller": "^24.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely! Lemme add that.

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ccharly ccharly enabled auto-merge (squash) February 14, 2025 15:42
@ccharly ccharly disabled auto-merge February 14, 2025 15:42
@ccharly ccharly enabled auto-merge (squash) February 14, 2025 15:43
@ccharly ccharly merged commit 1e5b340 into main Feb 14, 2025
133 checks passed
@ccharly ccharly deleted the release/299.0.0 branch February 14, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants