-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 299.0.0 #5318
Release 299.0.0 #5318
Conversation
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected] |
@@ -73,9 +73,9 @@ | |||
"typescript": "~5.2.2" | |||
}, | |||
"peerDependencies": { | |||
"@metamask/accounts-controller": "^23.0.0", | |||
"@metamask/accounts-controller": "^24.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accounts controller bump will not affect bridge controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can we add at least the changelog entry for this bump under unreleased section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely! Lemme add that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@metamask/network-controller": "^22.0.0", | ||
"@metamask/transaction-controller": "^45.0.0" | ||
"@metamask/transaction-controller": "^46.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transaction controller bump caused by accounts-controller peer dep bump. Also shouldn't affect bridge controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can we add at least the changelog entry for this bump under unreleased section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely! Lemme add that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: cryptodev-2s <[email protected]>
"@metamask/network-controller": "^22.0.0", | ||
"@metamask/transaction-controller": "^45.0.0" | ||
"@metamask/transaction-controller": "^46.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely! Lemme add that.
@@ -73,9 +73,9 @@ | |||
"typescript": "~5.2.2" | |||
}, | |||
"peerDependencies": { | |||
"@metamask/accounts-controller": "^23.0.0", | |||
"@metamask/accounts-controller": "^24.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely! Lemme add that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Explanation
This is a controller release that includes the first version of the
MultichainNetworkController
, which also includeAccountController
updates. The other version bumps are related to updating their peer dependency version of accounts controller.References
Related to: #804
Changelog
Checklist