Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add KeyringController:withKeyring action #5332

Merged
merged 3 commits into from
Feb 14, 2025
Merged

feat: add KeyringController:withKeyring action #5332

merged 3 commits into from
Feb 14, 2025

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Feb 14, 2025 •
edited
Loading

Explanation

This PR adds a KeyringController:withKeyring action with KeyringController.withKeyring as handler

References

Changelog

@metamask/keyring-controller

  • ADDED: Add KeyringController:withKeyring action

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mikesposito mikesposito requested a review from a team as a code owner February 14, 2025 13:42
@mikesposito mikesposito requested a review from a team as a code owner February 14, 2025 13:55
Gudahtt
Gudahtt approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mathieuartu
mathieuartu approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@mathieuartu mathieuartu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! LGTM!

@mikesposito mikesposito enabled auto-merge (squash) February 14, 2025 16:11
@mikesposito mikesposito merged commit 731da56 into main Feb 14, 2025
133 checks passed
@mikesposito mikesposito deleted the mikesposito/add-withkeyring-action branch February 14, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccharly ccharly ccharly approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@mathieuartu mathieuartu mathieuartu approved these changes

@danroc danroc danroc approved these changes

Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikesposito @ccharly @Gudahtt @mathieuartu @danroc