Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade allow-scripts; add preinstall-always-fail #109

Merged
merged 7 commits into from
Feb 6, 2025
Merged

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Nov 29, 2023

This commit aligns this repo with the module template:

  • Bump @lavamoat/allow-scripts to ^2.3.1
  • Add @lavamoat/preinstall-always-fail, as it was being configured in the manifest, but not actually installed

This aligns this repo with our module template.
This commit aligns this repo with the module template:

- Bump `@lavamoat/allow-scripts` to ^2.3.1
- Add `@lavamoat/preinstall-always-fail`, as it was being configured in
  the manifest, but not actually installed
@mcmire mcmire requested a review from a team as a code owner November 29, 2023 19:26
Copy link

socket-security bot commented Nov 29, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@isaacs/[email protected] None 0 27.8 kB isaacs
npm/@lavamoat/[email protected] None 0 0 B
npm/@lavamoat/[email protected] 🔁 npm/@lavamoat/[email protected] None 0 0 B
npm/@lavamoat/[email protected] 🔁 npm/@lavamoat/[email protected] None 0 3.53 kB lmbot
npm/@npmcli/[email protected] environment, network 0 17.7 kB npm-cli-ops
npm/@npmcli/[email protected] filesystem 0 26.5 kB lukekarrys
npm/@npmcli/[email protected] environment, filesystem 0 23 kB npm-cli-ops
npm/@npmcli/[email protected] 🔁 npm/@npmcli/[email protected] None 0 1.87 kB lukekarrys
npm/@npmcli/[email protected] filesystem 0 39.5 kB npm-cli-ops
npm/@npmcli/[email protected] 🔁 npm/@npmcli/[email protected] environment 0 12.2 kB npm-cli-ops
npm/@npmcli/[email protected] 🔁 npm/@npmcli/[email protected] None 0 18.3 kB npm-cli-ops
npm/@pkgjs/[email protected] None 0 74.2 kB oss-bot
npm/[email protected] 🔁 npm/[email protected] None 0 4.83 kB lukekarrys
npm/[email protected] network 0 31.5 kB tootallnate
npm/[email protected] None 0 6.69 kB sindresorhus
npm/[email protected] filesystem 0 20.7 kB npm-cli-ops
npm/[email protected] None 0 11.5 kB juliangruber
npm/[email protected] filesystem 0 63.7 kB npm-cli-ops
npm/[email protected] None 0 5.51 kB sindresorhus
npm/[email protected] 🔁 npm/[email protected] None +2 42 kB oss-bot
npm/[email protected] filesystem 0 12.2 kB npm-cli-ops
npm/[email protected] 🔁 npm/[email protected] None +2 37 kB satazor
npm/[email protected] None 0 13.6 kB komagata
npm/[email protected] None 0 7.12 kB andris
npm/[email protected] None 0 12.3 kB achingbrain
npm/[email protected] None 0 37.3 kB sssayegh
npm/[email protected] shell 0 69 kB isaacs
npm/[email protected] 🔁 npm/[email protected] None 0 31.4 kB ljharb
npm/[email protected] 🔁 npm/[email protected] None 0 32.5 kB isaacs
npm/[email protected] None 0 8.77 kB ljharb
npm/[email protected] None 0 26.6 kB npm-cli-ops
npm/[email protected] None 0 35.9 kB kornel
npm/[email protected] network 0 23.3 kB tootallnate
npm/[email protected] network 0 35.2 kB tootallnate
npm/[email protected] None 0 349 kB ashtuchkin
npm/[email protected] None 0 4.4 kB sindresorhus
npm/[email protected] None 0 12.1 kB npm-cli-ops
npm/[email protected] None 0 177 kB beaugunderson
npm/[email protected] 🔁 npm/[email protected] None 0 33.5 kB ljharb
npm/[email protected] None 0 2.94 kB watson
npm/[email protected] environment, filesystem 0 43 kB isaacs
npm/[email protected] environment 0 297 kB isaacs
npm/[email protected] 🔁 npm/[email protected] None 0 46.9 kB andyperlitch
npm/[email protected] 🔁 npm/[email protected] None 0 9.94 kB npm-cli-ops
npm/[email protected] None 0 804 kB isaacs
npm/[email protected] network 0 52.8 kB npm-cli-ops
npm/[email protected] environment 0 435 kB isaacs
npm/[email protected] None 0 4.96 kB isaacs
npm/[email protected] environment, network 0 46.8 kB npm-cli-ops
npm/[email protected] None 0 3.77 kB isaacs
npm/[email protected] None 0 7 kB isaacs
npm/[email protected] None 0 124 kB isaacs
npm/[email protected] 🔁 npm/[email protected] None 0 6.72 kB styfle
npm/[email protected] None 0 28.6 kB blakeembrey
npm/[email protected] 🔁 npm/[email protected] None +4 2.45 MB nodejs-foundation
npm/[email protected] 🔁 npm/[email protected] None 0 26.2 kB npm-cli-ops
npm/[email protected] None 0 28.2 kB npm-cli-ops
npm/[email protected] None 0 6.21 kB npm-cli-ops
npm/[email protected] None 0 19.2 kB npm-cli-ops
npm/[email protected] None 0 16.5 kB npm-cli-ops
npm/[email protected] None 0 8.69 kB sindresorhus
npm/[email protected] None 0 36.5 kB isaacs
npm/[email protected] filesystem 0 535 kB isaacs
npm/[email protected] None 0 3.04 kB iarna
npm/[email protected] None 0 15.6 kB achingbrain
npm/[email protected] filesystem 0 5.16 kB lukekarrys
npm/[email protected] 🔁 npm/[email protected] None +1 91.8 kB matteo.collina
npm/[email protected] 🔁 npm/[email protected] environment 0 145 kB ljharb
npm/[email protected] None 0 32.2 kB tim-kos
npm/[email protected] None 0 96.7 kB fritzy, gar, hashtagchris, ...3 more
npm/[email protected] None 0 77 kB isaacs
npm/[email protected] None 0 138 kB joshglazebrook
npm/[email protected] network 0 25.5 kB tootallnate
npm/[email protected] network 0 156 kB joshglazebrook
npm/[email protected] None 0 39.9 kB alexei
npm/[email protected] None 0 38.7 kB npm-cli-ops
npm/[email protected] None 0 0 B
npm/[email protected] None 0 0 B
npm/[email protected] None 0 9.18 kB ljharb
npm/[email protected] None 0 400 kB sindresorhus
npm/[email protected] None 0 3.41 kB lukekarrys
npm/[email protected] None 0 2.58 kB lukekarrys
npm/[email protected] unsafe 0 7.77 kB npm-cli-ops
npm/[email protected] environment 0 7.5 kB npm-cli-ops
npm/[email protected] None 0 0 B
npm/[email protected] filesystem 0 12.2 kB npm-cli-ops
npm/[email protected] 🔁 npm/[email protected] None 0 128 kB oss-bot
npm/[email protected] 🔁 npm/[email protected], npm/[email protected] None 0 292 kB oss-bot

🚮 Removed packages: npm/@yarnpkg/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Nov 29, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@npmcli/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/@npmcli/[email protected], npm/@lavamoat/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Base automatically changed from bump-to-node-18 to main November 29, 2023 19:52
@mcmire
Copy link
Contributor Author

mcmire commented Nov 29, 2023

Socket errors are okay. We own the @lavamoat/* packages, and ljharb, lukekarrys, and gar are trusted authors.

package.json Outdated Show resolved Hide resolved
@mcmire
Copy link
Contributor Author

mcmire commented Feb 6, 2025

@SocketSecurity ignore npm/@lavamoat/[email protected]

This is OK, this is our package.

@mcmire
Copy link
Contributor Author

mcmire commented Feb 6, 2025

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/@npmcli/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/@npmcli/[email protected]

These are OK, these are all direct or transitive dependencies of allow-scripts. And the new authors are OK too, they are all known actors.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 532580d into main Feb 6, 2025
11 checks passed
@mcmire mcmire deleted the align-lavamoat branch February 6, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants