Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use asset ticker else asset.symbol for Price component header text #12971

Conversation

nickewansmith
Copy link
Contributor

Description

  1. What is the reason for the change?

Ethereum assets on all chains show up on asset details page header as Ethereum(Ethereum)

  1. What is the improvement/solution?

Ethereum assets on all chains show up on asset details page header as Ethereum(ETH) as we use asset.ticker but default to asset.symbol used previously

Related issues

Fixes: #12960
Fixes: https://consensyssoftware.atlassian.net/browse/STAKE-915

Manual testing steps

  • Click on the native Ethereum asset on any chain to enter the Asset Detail page for that asset
  • The asset detail title should be Ethereum(ETH)

Screenshots/Recordings

Before

image

After

simulator_screenshot_AF5DF4F3-4D98-4272-9E93-3125A205D5C3

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@nickewansmith nickewansmith marked this pull request as ready for review January 13, 2025 23:36
@nickewansmith nickewansmith requested a review from a team as a code owner January 13, 2025 23:36
@nickewansmith nickewansmith added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 13, 2025
@nickewansmith
Copy link
Contributor Author

@nickewansmith nickewansmith added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 353fa1a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/530a86f0-6270-42b5-8875-4c684fae30c3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@nickewansmith nickewansmith added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b412c09
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eba34de4-0fa4-41fe-a5e2-86fcfe4257e2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

…hains-have-title-ethereum-ethereum-on-the-asset-detail-page
@nickewansmith nickewansmith added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9a993a8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/50f53c98-db89-4787-bf05-62b0b0b7cac3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

…hains-have-title-ethereum-ethereum-on-the-asset-detail-page
@nickewansmith nickewansmith added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7bc60ef
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/643c1f8a-0975-4cba-b1ce-49a4552b0fef

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@nickewansmith nickewansmith added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jan 22, 2025
…hains-have-title-ethereum-ethereum-on-the-asset-detail-page
@nickewansmith nickewansmith removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 22, 2025
@nickewansmith nickewansmith added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 22, 2025
Copy link
Contributor

github-actions bot commented Jan 22, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5f4acec
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/75d101be-40ad-4a57-9f26-a88e26b17021

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

…hains-have-title-ethereum-ethereum-on-the-asset-detail-page
@nickewansmith nickewansmith added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 28, 2025
Copy link
Contributor

github-actions bot commented Jan 28, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b93a191
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c9f5cb45-e7f5-4da5-a066-2ecafddb891c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.79%. Comparing base (217ae16) to head (b93a191).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12971      +/-   ##
==========================================
+ Coverage   60.75%   60.79%   +0.04%     
==========================================
  Files        1917     1917              
  Lines       42834    42834              
  Branches     5757     5759       +2     
==========================================
+ Hits        26025    26043      +18     
+ Misses      15060    15040      -20     
- Partials     1749     1751       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickewansmith nickewansmith added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 3d62fde Jan 28, 2025
43 checks passed
@nickewansmith nickewansmith deleted the STAKE-915-mobile-native-eth-assets-for-all-chains-have-title-ethereum-ethereum-on-the-asset-detail-page branch January 28, 2025 20:21
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Asset Detail Page Header asset name and symbol/ticker are the same for native assets
4 participants