Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NftGrid view #12983

Merged
merged 65 commits into from
Jan 28, 2025
Merged

feat: NftGrid view #12983

merged 65 commits into from
Jan 28, 2025
+1,174 −2,424

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Jan 14, 2025 •
edited
Loading

Description

Introduces new UI to display NFTs. They now should appear in a grid, rather than in nested expandable list items as they were previously. I'm also removing a lot of dead code related to the previous implementation. I needed to tweak one of the e2e tests on android due to a faulty selector.

More specifically, this is what was added/removed:

  1. NftGrid component. This is the majority of the newly introduced code
  2. Removal of much of the Collectibles namespaced components that were no longer being used, now that NftGrid is a thing
  3. Refactor nft-details.spec.js to account for new UI

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-248

Manual testing steps

  1. Nfts should appear in Nft tab in a grid
  2. Nfts should refresh on pulldown, as expected
  3. Nfts should respect send flow
  4. Long press -> ActionSheet -> Hide & Refresh actions should work as intended

Screenshots/Recordings

Screen.Recording.2025-01-27.at.12.16.02.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish added team-assets Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 14, 2025
@gambinish gambinish changed the title Feat/nft grid view feat: NftGrid view Jan 14, 2025
@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b61907c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b96468b3-449c-4a51-8250-71abc69ddc20

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 77dbf93
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5ab3b100-4252-4783-a69c-b66a530b9626

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 430ddf9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/da43c8b8-36d6-41d2-a5d9-b6a85ddee49f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 18, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9bfd19d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/efe63ed5-3f6c-4dbe-bea5-d8bb7d1503fa

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@gambinish gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: dbace44
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/65bab946-4722-4297-8fe8-2ecde65d9a45

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ca9b2ba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d416ed57-2e6c-4ada-a5e0-0669f0c4a86c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 48feb23
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c5032158-ffb8-46f2-b656-d6c3976382d5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d89e334
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0f2cc2e6-05ba-467e-abb7-bffff2944a0b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
64.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cortisiko
cortisiko approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from an e2e test perspective. Good work on modifying the e2e 🙏

vinnyhoward
vinnyhoward approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a comment for privacy mode and tests but its not a blocker

@gambinish gambinish added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 6ab0549 Jan 28, 2025
45 checks passed
@gambinish gambinish deleted the feat/nft-grid-view branch January 28, 2025 00:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gambinish @cortisiko @Prithpal-Sooriya @vinnyhoward @metamaskbot