Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppMetadataController to Engine #13739

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frankvonhoven
Copy link
Contributor

Description

Implements Metadata controller in mobile

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@frankvonhoven frankvonhoven added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team labels Feb 26, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@@ -230,6 +230,7 @@ import {
import { createMultichainAssetsController } from './controllers/MultichainAssetsController';
///: END:ONLY_INCLUDE_IF
import { createMultichainNetworkController } from './controllers/MultichainNetworkController';
import { AppMetadataController } from '@metamask/app-metadata-controller';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankvonhoven please take a look at the controller integration guidelines here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants