Fix: Multichain balances #13742
Open
Fix: Multichain balances #13742
+1,214
−326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
Have feedback? Participate in our User Experience Survey 📊 |
owencraston
force-pushed
the
fix/multichain-balances
branch
2 times, most recently
from
896d23e to
290f36d
Compare
tommasini
reviewed
Feb 28, 2025
app/core/Engine/Engine.ts
Outdated
| @@ -454,6 +461,27 @@ export class Engine { | |||
| multichainRatesControllerMessenger, | |||
| multichainRatesController, | |||
| ); | |||
|
|
|||
| const cronjobControllerMessenger = this.controllerMessenger.getRestricted({ | |||
There was a problem hiding this comment.
Now we have a folders to have the messengers on, we can start to move this there, this is a new pattern introduced by this PR (We can address it later so we unblock stuff)
tommasini
reviewed
Feb 28, 2025
| Solana = `${SolScope.Mainnet}/token:EPjFWdd5AufqSSqeM2qN1xzybapC8G4wEGGkZwyTDt1v`, | ||
| SolanaDevnet = `${SolScope.Devnet}/token:EPjFWdd5AufqSSqeM2qN1xzybapC8G4wEGGkZwyTDt1v`, | ||
| SolanaTestnet = `${SolScope.Testnet}/token:EPjFWdd5AufqSSqeM2qN1xzybapC8G4wEGGkZwyTDt1v`, | ||
| Solana = `${SolScope.Mainnet}/slip44:501`, |
|
Where is this event "ExecutionService:unhandledError" coming from? Weird error! |
owencraston
force-pushed
the
fix/multichain-balances
branch
from
290f36d to
58a55e1
Compare
owencraston
force-pushed
the
fix/multichain-balances
branch
from
28d1be3 to
6067fc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the broken balances for Solana on mobile. There were a series of updates that broke the balances. This PR addresses this issue with the following..
This PR also migrates all of the Multichain controllers to use the latest "init" pattern. These changes were modelled off of the accounts controller.
NOTE: Bitcoin Balances are still broken and likely requires a the snap to be updated. BTC is not a priority for now.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-02-28.at.9.36.58.PM.mov
After
Screen.Recording.2025-02-28.at.9.07.51.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist