Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Snaps UI Selector component #13747

Merged
merged 5 commits into from
Mar 3, 2025
Merged

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Feb 27, 2025

Description

Implement the SnapUISelector component and tweak some additional components, such as fixing the label variant for all form inputs.

Related issues

Closes: MetaMask/snaps#3176

Manual testing steps

Use the Send flow example Snap

Screenshots/Recordings

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Feb 27, 2025
@FrederikBolding FrederikBolding force-pushed the fb/add-snaps-ui-selector branch from 1d70ba4 to 0cba2ea Compare February 27, 2025 16:25
@FrederikBolding FrederikBolding force-pushed the fb/add-snaps-ui-selector branch from 76bc817 to 9e3b5be Compare February 27, 2025 18:04
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 3, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 13.63636% with 38 lines in your changes missing coverage. Please review.

Project coverage is 63.55%. Comparing base (256bc97) to head (7577bff).
Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
...ponents/UI/Snaps/SnapUISelector/SnapUISelector.tsx 7.14% 26 Missing ⚠️
...onents/Snaps/SnapUIRenderer/components/selector.ts 16.66% 5 Missing ⚠️
...s/UI/Snaps/SnapUISelector/SnapUISelector.styles.ts 20.00% 4 Missing ⚠️
...omponents/Snaps/SnapUIRenderer/components/field.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13747      +/-   ##
==========================================
+ Coverage   62.91%   63.55%   +0.64%     
==========================================
  Files        2035     2101      +66     
  Lines       44539    45373     +834     
  Branches     6050     6249     +199     
==========================================
+ Hits        28020    28837     +817     
+ Misses      14685    14652      -33     
- Partials     1834     1884      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 3, 2025
@FrederikBolding FrederikBolding marked this pull request as ready for review March 3, 2025 10:18
@FrederikBolding FrederikBolding requested review from a team as code owners March 3, 2025 10:18
Copy link
Contributor

github-actions bot commented Mar 3, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 96e73f7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5f8be356-e78a-42bb-a170-51f7967687b0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@FrederikBolding FrederikBolding changed the title feat: Add Snaps UI selector feat: Add Snaps UI Selector component Mar 3, 2025
tommasini
tommasini previously approved these changes Mar 3, 2025
david0xd
david0xd previously approved these changes Mar 3, 2025
@FrederikBolding FrederikBolding dismissed stale reviews from david0xd and tommasini via 6494eb3 March 3, 2025 11:50
@FrederikBolding FrederikBolding added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 3, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6494eb3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cfbf5064-5c5b-44b5-9a39-f7a13062f49e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarqubecloud bot commented Mar 3, 2025

@FrederikBolding FrederikBolding added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit 4cc0f07 Mar 3, 2025
42 of 43 checks passed
@FrederikBolding FrederikBolding deleted the fb/add-snaps-ui-selector branch March 3, 2025 12:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Selector component on mobile
5 participants