Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: STAKE-934 add earn controller to engine #13778

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Feb 28, 2025

Description

This PR adds the @metamask/earn-controller dependency and follows the modular controller init to add it to the Engine.

Related issues

Manual testing steps

  1. Start the app locally
  2. Ensure there isn't a crash: on boot, on account switch, and on network switch

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Matt561 Matt561 marked this pull request as ready for review February 28, 2025 18:03
@Matt561 Matt561 requested review from a team as code owners February 28, 2025 18:03
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Feb 28, 2025

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 95.2 kB metamaskbot

View full report↗︎

Have feedback? Participate in our User Experience Survey 📊

@Matt561 Matt561 force-pushed the feat/stake-934-add-earn-controller-to-engine branch from c1977d8 to a85b3d1 Compare February 28, 2025 22:03
amitabh94
amitabh94 previously approved these changes Feb 28, 2025
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Matt561 Matt561 force-pushed the feat/stake-934-add-earn-controller-to-engine branch 3 times, most recently from b500f68 to 93c4ec5 Compare February 28, 2025 23:18
@Matt561 Matt561 requested a review from amitabh94 February 28, 2025 23:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.54%. Comparing base (d1d22d7) to head (93c4ec5).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13778      +/-   ##
==========================================
+ Coverage   63.42%   63.54%   +0.12%     
==========================================
  Files        2093     2097       +4     
  Lines       45277    45316      +39     
  Branches     6234     6243       +9     
==========================================
+ Hits        28717    28797      +80     
+ Misses      14676    14637      -39     
+ Partials     1884     1882       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Matt561 Matt561 force-pushed the feat/stake-934-add-earn-controller-to-engine branch from 074b7a7 to e2fc165 Compare March 1, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants