fix: cp-7.42.0 improve performance of notifications loading when opening the app

[Prithpal-Sooriya]

Description

There is serious performance impact of loading notifications on startup. It is roughly a 2 second lag, and the app freezes during this process.
This is due to us processing the encryption key to be used for decrypting entries in UserStorage.
This persists the a cached encryption key using existing storage mechanisms to securely store this hashed key.

NOTE: This fix is an interim solution until we add e2e content keys for encryption (CC @mathieuartu @mirceanis)
MetaMask/core#5129

Related issues

Fixes:

Manual testing steps

1. Enable Notifications
2. Close the app
3. Open the app and unlock the wallet
   EXPECTED - you should not see any lag or app freezing.

Screenshots/Recordings

Before

https://www.loom.com/share/8951a714b9b34f79a3e988ed50f9f656?sid=ad2ff732-c893-49d6-bd4b-e7f13a3a08b5

After

https://www.loom.com/share/fe0afadcd49b46bbbafe219f95777fb6?sid=ca0df6aa-b5c5-4ffd-a5ee-bc811f0f1058

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ae42f91
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1f30f7ce-62b8-4581-b868-abb1e521f899

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[mathieuartu]

Thanks for all the context you added in your comments! LGTM!

Also, approving since there may be not enough time to get this directly in the controllers for this release, but the contents of this PR will be replaced soon by an implementation directly in UserStorageController

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8dedd2b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0809392a-80e5-4a3e-81a7-980249b2ed38

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3fdce4b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/080019da-3a6d-4eaa-9d55-62c4f121730a

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud