Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add URLSearchParams as a default endowment #3047

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

FrederikBolding
Copy link
Member

Add URLSearchParams as a default global to allow for easy modification of query strings for API calls. This was already somewhat available through URL.searchParams.

Closes #3044

@FrederikBolding FrederikBolding requested a review from a team as a code owner January 29, 2025 10:01
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (cc563af) to head (971758b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3047   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files         503      503           
  Lines       10996    10996           
  Branches     1685     1685           
=======================================
  Hits        10425    10425           
  Misses        571      571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 362208e into main Jan 29, 2025
167 checks passed
@FrederikBolding FrederikBolding deleted the fb/urlsearchparams branch January 29, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate exposing URLSearchParams to Snaps
2 participants