Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Here's a fun fact! Did you know the
NbtIo.read()
javadoc is wrong?Yep! They actually catch
IOException
's and rethrow them asCrashException
's, which are not a subclass ofIOException
and not stated in the javadoc.Anyways this PR catches those and prevents it from crashing the game, as well as creating a backup before overwriting the erroring settings.
Note: I kept the
IOException
catch and explicitly didn't make it create a backup, as that would indicate something might be wrong with the backup process, or IO operations. It will still allow the game to run, it will just overwrite the settings.How Has This Been Tested?
Checklist: