Rewrite build script #5091
Merged
Rewrite build script #5091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drastically cuts down on compilation times
remove git credentials from local git config, they are unused
provides wrapper validation & dependency caching
tl;dr improves error reporting on compilation
hopefully fix ClosedFileSystemException
Co-authored-by: machiecodes <[email protected]>
gradle wrapper executable already has execution permissions, you can verify with `ls -l gradlew`
|
Also one more thing: |
# Conflicts: # build.gradle # gradle.properties # gradle/wrapper/gradle-wrapper.properties
i looked into it and it seems like i can't change these without the changes being undone whenever we update the wrapper scripts through the gradle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Rewrite build script to make use of Kotlin DSL
Javadoc & sources jars are now only created if the
CIsystem property evaluates to true. This was done because it used to take up more than half of the build time despite being rarely used.Credits