-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0 #61
Conversation
For the sample.xml, I think this line should be updated to be a direct link to the schema, so something like this: - <MetronInfo xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="MetronInfo.xsd">
+ <MetronInfo xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://raw.githubusercontent.com/Metron-Project/metroninfo/master/schema/v1.0/MetronInfo.xsd"> |
The line: xsi:noNamespaceSchemaLocation="MetronInfo.xsd" specifies where the schema resides (here it is in the same folder as "Sample.xml"), and if your IDE supports it (like PyCharm, VSCode, etc) it will validate it live. Changing it to what you suggested would most likely give you some type of error saying the uri is invalid. |
Description looks good to me. I'll leave the technical validation to you. |
This PR is to finalize the v1.0 of the schema: