Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0 #61

Merged
merged 4 commits into from
Nov 22, 2024
Merged

v1.0 #61

merged 4 commits into from
Nov 22, 2024

Conversation

bpepple
Copy link
Member

@bpepple bpepple commented Nov 21, 2024

This PR is to finalize the v1.0 of the schema:

  • Move MetronInfo.xsd & Sample.xml to schema directory
  • Update tests
  • Update README

@bpepple bpepple self-assigned this Nov 21, 2024
@bpepple bpepple linked an issue Nov 21, 2024 that may be closed by this pull request
@bpepple bpepple marked this pull request as ready for review November 21, 2024 19:51
README.md Outdated Show resolved Hide resolved
@Buried-In-Code
Copy link
Member

Buried-In-Code commented Nov 22, 2024

For the sample.xml, I think this line should be updated to be a direct link to the schema, so something like this:

- <MetronInfo xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="MetronInfo.xsd">
+ <MetronInfo xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://raw.githubusercontent.com/Metron-Project/metroninfo/master/schema/v1.0/MetronInfo.xsd">

@bpepple
Copy link
Member Author

bpepple commented Nov 22, 2024

For the sample.xml, I think this line should be updated to be a direct link to the schema, so something like this:

- <MetronInfo xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="MetronInfo.xsd">
+ <MetronInfo xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://raw.githubusercontent.com/Metron-Project/metroninfo/master/schema/v1.0/MetronInfo.xsd">

The line: xsi:noNamespaceSchemaLocation="MetronInfo.xsd" specifies where the schema resides (here it is in the same folder as "Sample.xml"), and if your IDE supports it (like PyCharm, VSCode, etc) it will validate it live. Changing it to what you suggested would most likely give you some type of error saying the uri is invalid.

@majora2007
Copy link
Contributor

Description looks good to me. I'll leave the technical validation to you.

@bpepple bpepple merged commit bf34c4c into master Nov 22, 2024
2 checks passed
@bpepple bpepple deleted the v1 branch November 22, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize MetronInfo v1 schema
3 participants